Skip to content

Binary L2 mass-loss fraction for thin accretion disk #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Binary L2 mass-loss fraction for thin accretion disk #830

wants to merge 23 commits into from

Conversation

pmocz
Copy link
Member

@pmocz pmocz commented May 29, 2025 •
edited
Loading

This PR begins to implement some useful features for modeling thin accretion disks and mass transfer/loss in binary systems.

Here, we implement an internal function (made callable in run_stars_extras as binary_L2_mass_loss_fraction()) to

  • calculate the (outer) L2 mass-loss fraction according to Lu et al. (2023) "On rapid binary mass transfer -I. Physical model"

and adds unit tests

@pmocz pmocz requested review from matthiasfabry and mathren May 29, 2025 11:49
@pmocz pmocz self-assigned this May 29, 2025
@pmocz pmocz requested a review from orlox as a code owner May 29, 2025 11:49
@pmocz
Copy link
Member Author

pmocz commented Jun 5, 2025

Currently, this function calculates the fL2_{outer} mass loss using Kramers opacity law. It looks like this (e.g., for q=0.5, M_2=10 Msun, X=0.7, Z=0.02)

image

@pmocz
Copy link
Member Author

pmocz commented Jun 5, 2025

verified against: https://github.com/wenbinlu/L2massloss

warrickball
warrickball reviewed Jun 7, 2025
View reviewed changes
warrickball
warrickball reviewed Jun 7, 2025
View reviewed changes
warrickball
warrickball reviewed Jun 7, 2025
View reviewed changes
warrickball
warrickball reviewed Jun 7, 2025
View reviewed changes
warrickball
warrickball reviewed Jun 7, 2025
View reviewed changes
warrickball
warrickball reviewed Jun 7, 2025
View reviewed changes
warrickball
warrickball reviewed Jun 7, 2025
View reviewed changes
warrickball
warrickball reviewed Jun 7, 2025
View reviewed changes
warrickball
warrickball reviewed Jun 7, 2025
View reviewed changes
warrickball
warrickball reviewed Jun 7, 2025
View reviewed changes
warrickball
warrickball reviewed Jun 7, 2025
View reviewed changes
warrickball
warrickball reviewed Jun 7, 2025
View reviewed changes
warrickball
warrickball reviewed Jun 7, 2025
View reviewed changes
@warrickball
Copy link
Contributor

warrickball commented Jun 7, 2025 •
edited
Loading

I've suggested powN(x) instead of x**N for N > 2, following our code style for exponents, and a bit more constant re-use (even for such details as ⅔).

Also note that the published version of the reference is Lu et al. (2023), not (2022).

warrickball
warrickball reviewed Jun 7, 2025
View reviewed changes
warrickball
warrickball reviewed Jun 7, 2025
View reviewed changes
warrickball
warrickball reviewed Jun 7, 2025
View reviewed changes
warrickball
warrickball reviewed Jun 7, 2025
View reviewed changes
warrickball
warrickball reviewed Jun 7, 2025
View reviewed changes
@pmocz @warrickball
[ci skip] fix reference
d9ebdbc 
Co-authored-by: Warrick Ball <[email protected]>
@pmocz
Copy link
Member Author

pmocz commented Jun 8, 2025

Thanks for all the fixes to help with bit-for-bit reproduction across compilers, @warrickball !

@pmocz @warrickball
[ci skip] pow4
025f6c4 
Co-authored-by: Warrick Ball <[email protected]>
pmocz and others added 18 commits June 8, 2025 13:05
@pmocz @warrickball
[ci skip] constants
db66b05 
Co-authored-by: Warrick Ball <[email protected]>
@pmocz @warrickball
[ci skip] pow3
b3dfd96 
Co-authored-by: Warrick Ball <[email protected]>
@pmocz @warrickball
[ci skip] two_thirds
a15efe4 
Co-authored-by: Warrick Ball <[email protected]>
@pmocz @warrickball
[ci skip] 0.5
671fbb9 
Co-authored-by: Warrick Ball <[email protected]>
@pmocz @warrickball
[ci skip] pow3
b3b2f76 
Co-authored-by: Warrick Ball <[email protected]>
@pmocz @warrickball
[ci skip] pow4
9c89049 
Co-authored-by: Warrick Ball <[email protected]>
@pmocz @warrickball
[ci skip] pow 3 4
3673ed1 
Co-authored-by: Warrick Ball <[email protected]>
@pmocz @warrickball
[ci skip] pi2
447d2e3 
Co-authored-by: Warrick Ball <[email protected]>
@pmocz @warrickball
[ci skip] pow3 4
69b986d 
Co-authored-by: Warrick Ball <[email protected]>
@pmocz @warrickball
[ci skip] exp10
b001a80 
Co-authored-by: Warrick Ball <[email protected]>
@pmocz @warrickball
[ci skip] pow10
5302882 
Co-authored-by: Warrick Ball <[email protected]>
@pmocz @warrickball
[ci skip] pow10
db391f4 
Co-authored-by: Warrick Ball <[email protected]>
@pmocz @warrickball
[ci skip] pow10
4b6e4d0 
Co-authored-by: Warrick Ball <[email protected]>
@pmocz @warrickball
[ci skip] pow3
622649d 
Co-authored-by: Warrick Ball <[email protected]>
@pmocz @warrickball
[ci skip] pow3
4a98b07 
Co-authored-by: Warrick Ball <[email protected]>
@pmocz
fix constants
5ea89cf
@pmocz
[ci skip] fix more constants
b93ebc0
@pmocz
[ci skip] changelog
2713165
@pmocz pmocz requested a review from rhdtownsend as a code owner June 8, 2025 21:26
@pmocz pmocz mentioned this pull request Jun 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warrickball warrickball warrickball left review comments

@matthiasfabry matthiasfabry Awaiting requested review from matthiasfabry

@mathren mathren Awaiting requested review from mathren

@orlox orlox Awaiting requested review from orlox orlox is a code owner

@rhdtownsend rhdtownsend Awaiting requested review from rhdtownsend rhdtownsend is a code owner

Assignees

@pmocz pmocz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmocz @warrickball